Reviewers: ,

Message:
Even though this part is fixed, it would be important to combine all
consecutive
text parts of the tempo indication into one <text> tag. This would make
the
output neater, as there can be a very wide gap between the text and
metronome
mark, and the excessive space before the last bracket (as seen in the
issue).

With those issues out of the way, it should be easier to fix the more
important
bug: https://sourceforge.net/p/testlilyissues/issues/3778/

Thank you for reviewing this patch and for improving the SVG
functionality.

Description:
Issue 4678: Fix spaces in metronome mark

This change specifies the types of spaces used in the metronome
markings as comments. It also changes the type of space to non-breaking
around the equals sign. The change also improves readability by
combining chars into strings.

Please review this at https://codereview.appspot.com/323420043/

Affected files (+4, -6 lines):
  M scm/translation-functions.scm


Index: scm/translation-functions.scm
diff --git a/scm/translation-functions.scm b/scm/translation-functions.scm
index 0ed0deff0a24817edc4f53b42fb902313f0e75bc..e911b7c3c5f5209266f282034301e9d0a8f4160f 100644
--- a/scm/translation-functions.scm
+++ b/scm/translation-functions.scm
@@ -65,9 +65,8 @@ way the transposition number is displayed."
                                (list
                                 (make-simple-markup
                                         (number->string (car count)))
-                                (make-simple-markup " ")
-                                (make-simple-markup "–")
-                                (make-simple-markup " ")
+                                ; Spaces are thin U+2009
+                                (make-simple-markup " - ")
                                 (make-simple-markup
                                         (number->string (cdr count))))))
                              (else #f)))
@@ -75,9 +74,8 @@ way the transposition number is displayed."
                           (make-concat-markup
                            (list
                             (make-general-align-markup Y DOWN note-mark)
-                            (make-simple-markup " ")
-                            (make-simple-markup "=")
-                            (make-simple-markup " ")
+                            ; Spaces are non-breaking U+00A0
+                            (make-simple-markup " = ")
                             count-markup))
                           #f))
          (text-markup (if (not (null? text))


_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to