On Thu, Sep 21, 2017 at 9:28 AM, <carl.d.soren...@gmail.com> wrote:
> Literally, just add one line of code to the example in Shape Note Heads,
> in NR 1.1.4., that uses
> either \aikenThinHeads or \aikenThinHeadsMinor (no need to include
> both). No change in the text
> is necessary.
>
> All we want is a single demonstration of the command, not an exhaustive
> demonstration.
> The documentation policy is to show, don't tell, and to remove as much
> as possible. We
> assume the reader to be intelligent and able to extrapolate from given
> examples. The NR is,
> by design, NOT a tutorial.
>
> Literally, I think you should add two lines to the example -- one line
> for the \aikenThinHeads,
> and one line that is a duplicate of the scale shown for all of the other
> heads.
>
> THanks,
>
> Carl
>
> https://codereview.appspot.com/326510043/
All right, I'm giving up and asking for help. I'm attaching the patch
I tried to git-cl up to Rietveld, and it picked up lots of other
things from I believe the git pull -r I did just prior. I went to
Rietveld and deleted it.
Now, to get just this patch uploaded -- was I supposed to make a new
local branch first?
--
Karlin High
Missouri, USA
(aka "The Show-Me State")
From 633117b0e12e85286fc84d61e3b28e3c26591a81 Mon Sep 17 00:00:00 2001
From: Karlin High <karlinh...@gmail.com>
Date: Fri, 22 Sep 2017 13:39:35 -0500
Subject: [PATCH 2/2] DOC: NR 1.1.4 Shape Note Heads, Issue 5187 Add Thin Aiken
note heads
This issue adds a command for a note head style.
Here the documentation for note heads is updated for the new style.
---
Documentation/notation/pitches.itely | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/notation/pitches.itely b/Documentation/notation/pitches.itely
index d7fcd4d..3271016 100644
--- a/Documentation/notation/pitches.itely
+++ b/Documentation/notation/pitches.itely
@@ -3260,6 +3260,7 @@ Internals Reference:
@cindex note heads, Walker
@funindex \aikenHeads
+@funindex \aikenThinHeads
@funindex \sacredHarpHeads
@funindex \southernHarmonyHeads
@funindex \funkHeads
@@ -3275,6 +3276,8 @@ Funk (Harmonica Sacra), Walker, and Aiken (Christian Harmony) styles:
\relative c'' {
\aikenHeads
c, d e f g2 a b1 c \break
+ \aikenThinHeads
+ c,4 d e f g2 a b1 c \break
\sacredHarpHeads
c,4 d e f g2 a b1 c \break
\southernHarmonyHeads
@@ -3288,6 +3291,7 @@ Funk (Harmonica Sacra), Walker, and Aiken (Christian Harmony) styles:
@funindex \key
@funindex \aikenHeadsMinor
+@funindex \aikenThinHeadsMinor
@funindex \sacredHarpHeadsMinor
@funindex \southernHarmonyHeadsMinor
@funindex \funkHeadsMinor
@@ -3305,6 +3309,8 @@ major:
a b c d e2 f g1 a \break
\aikenHeadsMinor
a,4 b c d e2 f g1 a \break
+ \aikenThinHeadsMinor
+ a,4 b c d e2 f g1 a \break
\sacredHarpHeadsMinor
a,2 b c d \break
\southernHarmonyHeadsMinor
@@ -3320,6 +3326,8 @@ major:
@predefined
@code{\aikenHeads},
@code{\aikenHeadsMinor},
+@code{\aikenThinHeads},
+@code{\aikenThinHeadsMinor},
@code{\funkHeads},
@code{\funkHeadsMinor},
@code{\sacredHarpHeads},
--
2.1.4
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
