LGTM, thanks!
https://codereview.appspot.com/341140043/diff/1/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/341140043/diff/1/lily/stencil-integral.cc#newcode410 lily/stencil-integral.cc:410: int quantization = max (0, (int) (rounded * (x_scale + y_scale) * radius * M_PI / QUANTIZATION_UNIT / 4)); [Please use a line length of at most 78 characters if possible.] Is `max' really the right operation here? Or to ask differently: Does a negative value of `diameter' makes sense? All other values on the right side are non-negative... Or maybe the first argument of `max' should be 1, as in function `make_partial_ellipse_boxes'? https://codereview.appspot.com/341140043/ _______________________________________________ lilypond-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/lilypond-devel
