Can't review C++-code. Some concerns in the ly-file:
https://codereview.appspot.com/576540043/diff/578520043/ly/divisi_engraver.ly File ly/divisi_engraver.ly (right): https://codereview.appspot.com/576540043/diff/578520043/ly/divisi_engraver.ly#newcode3 ly/divisi_engraver.ly:3: % From define-context-properties.scm Here two new context-properties are defined: sharingParts and combineWithNext This shouldn't be done in a ly-file, but in define-context-properties.scm https://codereview.appspot.com/576540043/diff/578520043/ly/divisi_engraver.ly#newcode26 ly/divisi_engraver.ly:26: except the last element of each sublist." I don't understand the description. The commented example below (which should likely be part of the doc-string) uses cdr. But cdr is not a perdicate. Am I missing something? Anyway, such a thing should probably inserted in lily-library.scm https://codereview.appspot.com/576540043/diff/578520043/ly/divisi_engraver.ly#newcode39 ly/divisi_engraver.ly:39: (and (every Isn't it the same as (lset<= equal? y x) ? The whole thingy is used once (in the engraver definition below) I'd delete 'proper-subset?' and do (lset<= equal? y x) there. https://codereview.appspot.com/576540043/diff/578520043/ly/divisi_engraver.ly#newcode45 ly/divisi_engraver.ly:45: Here I stopped for now. Waiting for the next iteration of this patch. ;) https://codereview.appspot.com/576540043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
