On 2019/07/06 08:06:43, Malte Meyn wrote:

Thanks for the review!

Maybe the snipped should be renamed also.

Done.


https://codereview.appspot.com/570830043/diff/578780043/input/regression/misplaced-note-head-bug.ly
File input/regression/misplaced-note-head-bug.ly (right):


https://codereview.appspot.com/570830043/diff/578780043/input/regression/misplaced-note-head-bug.ly#newcode1
input/regression/misplaced-note-head-bug.ly:1: \version "2.19.16"
IIUC this should be the first version a feature is introduced or a bug
is fixed,
i. e. 2.21.0

Done.


https://codereview.appspot.com/570830043/diff/578780043/input/regression/misplaced-note-head-bug.ly#newcode5
input/regression/misplaced-note-head-bug.ly:5: texidoc = "Misplaced
note head
bug (issue 5303) should be fixed."
Maybe that comment can be more descriptive so that you don’t have to
search for
that issue to understand it? Something like “Note heads are placed on
the
correct side of the stem; layout-set-staff-size doesn’t change that
placement.”

Done (using a slightly different wording).

https://codereview.appspot.com/570830043/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to