[email protected] writes: > LGTM > > nit: please use the commit SHA1 for referencing previous code. It is > self-contained, and doesn't need the internet for understanding the > context.
For referencing previous issues, we have so far used the issue number, so that would be rather something to discuss on the list rather than as a side note. We have been able to transport the issue database across several different systems, so the issue numbers have proven a comparatively workable reference frame. Commit ids work just in Git. For information strictly related to a single commit, like when reverting a commit, a commit id is certainly a good reference but at least in the case of reverts, the issue number contained in the original commit message is also present. In addition, issue numbers tend to be associated with reports showing the history and rationale behind a change and often giving extensive other information like problem images. That's something we cannot attach to commits (or at least, this has not been attempted so far). -- David Kastrup
