Reviewers: ,
https://codereview.appspot.com/557440043/diff/547670043/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/557440043/diff/547670043/ly/music-functions-init.ly#newcode1319 ly/music-functions-init.ly:1319: 'origin (*location*) I'm curious about when it is important to provide 'origin (*location*) to make-music and when it is not. Some functions do it and some don't. Description: https://sourceforge.net/p/testlilyissues/issues/5771/ Remove an unnecessary (descend-to-context ... 'Score). I started looking for a reason for this code, but I lost interest once I saw how old it is. input/regression/partial-polymetric.ly seems to cover the relevant case, and it still passes after removing this code. Please review this at https://codereview.appspot.com/557440043/ Affected files (+7, -14 lines): M ly/music-functions-init.ly M scm/define-music-display-methods.scm Index: ly/music-functions-init.ly diff --git a/ly/music-functions-init.ly b/ly/music-functions-init.ly index f3893fab2ffb4062d60f496e63b978195b858c7c..42c1075f13c657bf38dbbc196b3fe6dfafd83cb3 100644 --- a/ly/music-functions-init.ly +++ b/ly/music-functions-init.ly @@ -1315,15 +1315,10 @@ that they share a staff with stems directed downward.") partial = #(define-music-function (dur) (ly:duration?) (_i "Make a partial measure.") - - ;; We use `descend-to-context' here instead of `context-spec-music' to - ;; ensure \partial still works if the Timing_translator is moved - (descend-to-context - (context-spec-music (make-music 'PartialSet - 'origin (*location*) - 'duration dur) - 'Timing) - 'Score)) + (context-spec-music (make-music 'PartialSet + 'origin (*location*) + 'duration dur) + 'Timing)) pitchedTrill = #(define-music-function Index: scm/define-music-display-methods.scm diff --git a/scm/define-music-display-methods.scm b/scm/define-music-display-methods.scm index 3516286c17def21193ce9074a17433e2b2171bb1..5cead5e0a1b9dfddad73d39356c47d49562391b7 100644 --- a/scm/define-music-display-methods.scm +++ b/scm/define-music-display-methods.scm @@ -988,12 +988,10 @@ Otherwise, return #f." Otherwise, return #f." (with-music-match (expr (music 'ContextSpeccedMusic + context-type 'Timing element (music - 'ContextSpeccedMusic - context-type 'Timing - element (music - 'PartialSet - duration ?duration)))) + 'PartialSet + duration ?duration))) (and ?duration (format #f "\\partial ~a"
