On 2020/02/25 19:50:34, lemzwerg wrote: > > Do we really want that many "no"s in the output > > Currently, you get this (in one long line): > > checking for guile-1.8 >= 1.8.2... checking for guile-2.2 >= 2.2.0... checking > for guile-2.0 >= 2.0.7... Package guile-2.0 was not found in the pkg-config > search path. Perhaps you should add the directory containing `guile-2.0.pc' to > the PKG_CONFIG_PATH environment variable No package 'guile-2.0' found > > With the above patch, you get > > checking for guile-1.8 >= 1.8.2... no > checking for guile-2.2 >= 2.2.0... no > checking for guile-2.0 >= 2.0.7... no > > ... > > ERROR: Please install required programs: guile-devel >= 1.8 > > So I think the many 'no' strings are the right thing to do.
Ah I missed that PKG_CHECK_MODULES already prints the "checking" lines. LGTM https://codereview.appspot.com/573570044/
