LGTM; some minor nits

https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile
File mf/GNUmakefile (right):

https://codereview.appspot.com/553580043/diff/571780045/mf/GNUmakefile#newcode130
mf/GNUmakefile:130: $(outdir)/emmentaler-brace.otf:
emmentaler-brace.fontforge.py $(outdir)/emmentaler-brace.otf-table \
maybe break line to make it shorter...

https://codereview.appspot.com/553580043/diff/571780045/mf/emmentaler-brace.fontforge.py
File mf/emmentaler-brace.fontforge.py (right):

https://codereview.appspot.com/553580043/diff/571780045/mf/emmentaler-brace.fontforge.py#newcode1
mf/emmentaler-brace.fontforge.py:1: #!@FONTFORGE@
Can we assume that FontForge's python support and is always enabled? 
Shall we check this?

https://codereview.appspot.com/553580043/diff/571780045/mf/emmentaler-brace.fontforge.py#newcode6
mf/emmentaler-brace.fontforge.py:6: import fontforge
importing 'fontforge' twice is correct?  If yes, please add a comment.

https://codereview.appspot.com/553580043/diff/571780045/mf/gen-emmentaler.fontforge.py
File mf/gen-emmentaler.fontforge.py (right):

https://codereview.appspot.com/553580043/diff/571780045/mf/gen-emmentaler.fontforge.py#newcode63
mf/gen-emmentaler.fontforge.py:63: alphabet 
="feta-alphabet%(design_size)d" % vars()
whitespace

https://codereview.appspot.com/553580043/

Reply via email to