Hello
What exactly am I supposed to be testing?
With or without make check?
I am struggling with all this 'back and forth' and with patches getting
created and tested by different people (worksforme, doesn't work for me
etc.).
Could someone put something in the tracker to know what I am to expect?
Thanks.
James
On 12/03/2020 09:22, d...@gnu.org wrote:
On 2020/03/12 08:01:03, hahnjo wrote:
On 2020/03/11 23:49:23, dak wrote:
[...]
GNU LilyPond 2.21.0
cp: cannot stat '19.sub{-*.signature,.ly,-1.eps,.log,.profile}': No
such file
or
directory
test results in ./out/test-output-distance
Traceback (most recent call last):
File "/tmp/lilypond-autobuild/scripts/build/output-distance.py",
line 1561,
in
<module>
main ()
File "/tmp/lilypond-autobuild/scripts/build/output-distance.py",
line 1546,
in
main
run_tests ()
File "/tmp/lilypond-autobuild/scripts/build/output-distance.py",
line 1495,
in
run_tests
test_compare_tree_pairs ()
File "/tmp/lilypond-autobuild/scripts/build/output-distance.py",
line 1330,
in
test_compare_tree_pairs
system ('cp 19.sub{-*.signature,.ly,-1.eps,.log,.profile}
dir1/subdir/')
File "/tmp/lilypond-autobuild/scripts/build/output-distance.py",
line 1304,
in
system
assert stat == 0, (stat, x)
AssertionError: (256, 'cp
19.sub{-*.signature,.ly,-1.eps,.log,.profile}
dir1/subdir/')
make[1]: ***
[/tmp/lilypond-autobuild/./scripts/build/GNUmakefile:19:
local-test] Error 1
make: *** [/tmp/lilypond-autobuild/GNUmakefile.in:328: test] Error 2
This looks like bash-ism which might explain why it works for Han-Wen
and me. I
agree with him that disabling the local-test invocation in
GNUmakefile.in is
probably the easiest solution for now. These tests haven't run for
years, so
we'll definitely be fine without them for a few more days.
dak@lola:/usr/local/tmp/lilypond$ dash
$ echo {1,2,3}
{1,2,3}
$
Ah yes. Since /bin/sh defaults to dash on Ubuntu (or doesn't it any
more?), I wonder how this escaped testing.
https://codereview.appspot.com/563730043/