On 2020/03/11 11:49:17, hanwenn wrote: > On Wed, Mar 11, 2020 at 11:16 AM <mailto:[email protected]> wrote: > > > > > > > https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile > > File scripts/build/GNUmakefile (right): > > > > > https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile#newcode19 > > scripts/build/GNUmakefile:19: $(PYTHON) output-distance.py --test > > This is wrong in 2 regards: > > 1) This should be local-test as also discussed for python/ > > done. > > > 2) output-distance.py is not copied over to the build tree, so my build > > fails. I think patchy didn't see this problem because it's only running > > done. > > > 'make test' and James skipped 'make check' for the last patchset because > > you wrote "This means you can't run a regression test between the state > > before and after this change." (which I think is not true; at least it > > worked for me). > > I added backward compat code. > > http://codereview.appspot.com/563730043 > > > https://codereview.appspot.com/581770043/ > > > > -- > Han-Wen Nienhuys - mailto:[email protected] - http://www.xs4all.nl/~hanwen
commit 5e87f62c45263940151f46e94b1cd2cee3f0c601 Merge: 3baa13d1a5 b02d93b9e8 Author: Han-Wen Nienhuys <[email protected]> Date: Wed Mar 11 09:00:59 2020 +0100 Merge branch 'output-distance-test' into staging https://sourceforge.net/p/testlilyissues/issues/5824 http://codereview.appspot.com/581770043 https://codereview.appspot.com/581770043/
