Reviewers: lemzwerg, Message: On 2020/04/18 05:53:25, lemzwerg wrote: > https://codereview.appspot.com/567450043/diff/555680043/lily/performance-scheme.cc#oldcode31 > lily/performance-scheme.cc:31: LY_DEFINE (ly_performance_set_header_x, > "ly:performance-set-header!", > Will this removal need a `convert-ly` warning?
It doesn't strike me as important, but I don't have much experience with this kind of decision. Description: https://sourceforge.net/p/testlilyissues/issues/5917/ Change ly:performance-header into ly:performance-headers, returning a list of visible header modules from innermost to outermost. Before, only the innermost header was provided, so the values of variables defined in outer headers were not accessible. If the \midi block defines a function called after-writing, LilyPond calls it after writing the MIDI file. Apart from its use in regression- testing ly:performance-headers, it offers a way for an advanced user to dump metadata associated with each performance. For example, the function could open a file and dump all header variables in YAML format for use in a scripted workflow where the information ends up in ID3 tags in an mp3 file. Please review this at https://codereview.appspot.com/567450043/ Affected files (+84, -46 lines): A input/regression/midi-after-writing.ly M lily/book.cc M lily/include/performance.hh M lily/performance.cc M lily/performance-scheme.cc M scm/midi.scm
