On Aug 31, 2023, at 07:38, Jean Abou Samra <j...@abou-samra.fr> wrote: > > > >> Le 31 août 2023 à 13:22, Dan Eble <dan@lyric.works> a écrit : >> >> My opinion hasn't changed since we instituted the automation. The previous >> discussion is in the archive. > > I couldn't find it. Do you happen to have a link at hand?
Sorry for the confusing couple of slightly different emails earlier. My internet connection was up and down and I got confused about what was actually sent. I'm sure we discussed the issue of draft reviews, but I can't find it in the list archive either. We probably discussed it in one of the trial MRs when we were evaluating GitLab. My opinion was that we should let "Draft:" do what it was designed to do (prevent merging) and otherwise ignore it. I didn't think it should prevent CI pipelines and review because such feedback is useful even for draft work. If people want to prevent Draft MRs from advancing to Patch::countdown, well, I don't see either harm or benefit in it; however, making Draft equivalent to Patch::needs_work would be giving something up. — Dan
