On Thu, Mar 3, 2011 at 8:03 AM, Vishwanath Sripathy <vishwanath.sripa...@linaro.org> wrote: > On Wed, Mar 2, 2011 at 4:35 AM, Nicolas Pitre <nicolas.pi...@linaro.org> > wrote: >> On Mon, 28 Feb 2011, Nicolas Pitre wrote: >> >>> On Mon, 28 Feb 2011, Vishwanath Sripathy wrote: >>> >>> > Hi Nicolas, >>> > >>> > Attached patch set has support for MPU DVFS (cpufreq) on OMAP4 and >>> > these are rebased against latest .38 linaro kernel. >>> > omap cpufreq driver changes are already posted to lo >>> > (https://patchwork.kernel.org/patch/589081/) and OMAP4 DVFS layer >>> > changes will be upstreamed once Basic DVFS framework is accepted. >>> > >>> > Kindly let me know if you can merge these patches for .38 linaro kernel. >>> >>> Merged. >>> >>> BTW, I don't have an intimate knowledge about the things those patches >>> touch. So in the future that would be helpful if you can gather some >>> review acknowledgements in the form of Acked-by or Reviewed-by tags from >>> some other people. Thanks. >> >> Also, I got the following build breakage report: >> >> LD .tmp_vmlinux1 >> arch/arm/mach-omap2/built-in.o: In function `omap_target': >> /opt/git/ubuntu/roc/natty/arch/arm/mach-omap2/omap2plus-cpufreq.c:118: >> undefined reference to `omap_device_scale' >> arch/arm/plat-omap/built-in.o: In function `omap_device_build_ss': >> /opt/git/ubuntu/roc/natty/arch/arm/plat-omap/omap_device.c:490: >> undefined reference to `omap_dvfs_register_device' >> make[2]: *** [.tmp_vmlinux1] Error 1 >> make[1]: *** [sub-make] Error 2 >> make[1]: Leaving directory `/opt/git/ubuntu/roc/natty' >> make: *** [/opt/git/ubuntu/roc/natty/debian/stamps/stamp-build-omap4] >> Error 2 >> >> I fixed it like this: >> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile >> index 86a54ca..898fffe 100644 >> --- a/arch/arm/mach-omap2/Makefile >> +++ b/arch/arm/mach-omap2/Makefile >> @@ -65,7 +65,7 @@ obj-$(CONFIG_ARCH_OMAP2) += pm24xx.o >> obj-$(CONFIG_ARCH_OMAP2) += sleep24xx.o pm_bus.o voltage.o >> obj-$(CONFIG_ARCH_OMAP3) += pm34xx.o sleep34xx.o voltage.o \ >> cpuidle34xx.o pm_bus.o dvfs.o >> -obj-$(CONFIG_ARCH_OMAP4) += pm44xx.o voltage.o pm_bus.o >> +obj-$(CONFIG_ARCH_OMAP4) += pm44xx.o voltage.o pm_bus.o dvfs.o >> obj-$(CONFIG_PM_DEBUG) += pm-debug.o >> obj-$(CONFIG_OMAP_SMARTREFLEX) += sr_device.o smartreflex.o >> obj-$(CONFIG_OMAP_SMARTREFLEX_CLASS3) += smartreflex-class3.o >> Please confirm this is OK, or provide an additional patch. > This looks fine to me. Thanks for the fix. > btw which defconfig threw up this error? I had built > omap2plus_defconfig and it went all fine. > > Vishwa
Vishwa, Linaro uses its own (rather heavy-weight) configuration that includes almost everything in as modules so that a variety of USB devices, protocols and other features work. /Amit _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
