On Sun, Mar 20, 2011 at 9:42 PM, Shawn Guo <shawn....@linaro.org> wrote: > This patch set is to take sdhci device driver specific things out > from sdhci-pltfm.c and make them self registered. Here are the > difference it makes. > > * Get the sdhci device driver follow the Linux trend that driver > take the registration by its own > * sdhci-pltfm.c becomes significantly simpler and only has common > support functions there > * All sdhci device specific stuff are going back its own driver > * The dt and non-dt support share the same pair of .probe and > .remove hooks.
Fantastic! Thanks for taking this on. I'll make a few comments, but this series really needs to be reposted to both the linux-kernel and linux-mmc lists. g. > > The first one patch adds common support function into sdhci-pltfm.c > when changing sdhci-esdhc-imx driver, while the last one clean up > sdhci-pltfm.c when changing sdhci-tegra driver. > > Only the patch of sdhci-esdhc-imx are tested on hardware, and others > are just build tested. > > Regards, > Shawn > > Shawn Guo (5): > mmc: sdhci: make sdhci-esdhc-imx driver self registered > mmc: sdhci: make sdhci-cns3xxx driver self registered > mmc: sdhci: make sdhci-dove driver self registered > mmc: sdhci: make sdhci-tegra driver self registered > mmc: sdhci: update Makefile/Kconfig for sdhci_pltfm change > > drivers/mmc/host/Kconfig | 24 +++-- > drivers/mmc/host/Makefile | 11 +- > drivers/mmc/host/sdhci-cns3xxx.c | 68 +++++++++++++- > drivers/mmc/host/sdhci-dove.c | 70 +++++++++++++- > drivers/mmc/host/sdhci-esdhc-imx.c | 98 +++++++++++++++---- > drivers/mmc/host/sdhci-pltfm.c | 165 ++----------------------------- > drivers/mmc/host/sdhci-pltfm.h | 14 ++- > drivers/mmc/host/sdhci-tegra.c | 189 > +++++++++++++++++++++--------------- > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
