On Tue, Mar 22, 2011 at 4:05 PM, Guilherme Salgado <guilherme.salg...@linaro.org> wrote: > On Mon, 2011-03-21 at 18:24 +0000, Peter Maydell wrote: >> On 18 March 2011 23:29, Guilherme Salgado <guilherme.salg...@linaro.org> >> wrote: >> > I'm currently working on the PatchTracking[1] spec and, wrt patch >> > series, I'm wondering whether you consider the patches that are part of >> > a series to be separate or the series to be a single entity? >> >> Depends. By putting a patchset into a series I definitely mean >> that in some ways it should be considered a single entity -- so >> for instance in my list of pending qemu patches a series is a >> single list entry, and generally they're semantically related >> changes intended to be all applied together. On the other hand >> sometimes you do want to think about the patches separately -- >> sometimes patches 1,4,5 get reviewed OK and 2,3 rejected for >> rework; occasionally a partial patchset is committed. > > Fair enough. > >> So: a series is a single entity containing a lot of separate >> patches; put another way, what's the purpose for which you >> want to decide whether it's one thing or a whole pile? :-) > > That's to decide whether we should count the patches that belong to a > series individually or not.
I don't have a strong opinion on this, but given that designing a decent patch series, reworking them, splitting them up etc. is more work than committing everything from top i don't see why the patches shouldn't be counted. Also if other folks run statistic on contributions to lets say kernel.org they typically just count patches/commits and not series afaiui. -- - Alexander _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
