On 14 November 2011 16:37, Nicolas Pitre <nicolas.pi...@linaro.org> wrote: > On Mon, 14 Nov 2011, Vincent Guittot wrote: > >> Hi Nicolas, >> >> Could you pull the sched_mc code from >> >> git://git.linaro.org/people/vingu/kernel.git on the branch sched_mc_for_11.11 >> >> This branch is rebased on your tree and contains sched_mc optimization >> code as well as some patches, which are in mainline. These additional >> patches solve various issues on features that are used by sched_mc >> optimization. > > OK, merged and pushed out. > > I however have some suggestions for next time: > > 1. When including mainline patches, please include a reference to the > original commit ID in the commit message of the included patch. > > 2. Please try to be more explicit about the reasons for your commits, > especially those which are not immediately obvious. Stating _what_ > you are doing is good, but elaborating a bit more on _why_ is even > more important for reviewers. > > 3. Try to gather some acked-by/reviewed-by tags so at least someone else > more familiar with the issues at hand is confirming the > goodness of your patch. I'm not able to make that judgement call > alone for everything. >
ok, I will take your suggestion into account for the next time Thanks, _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
