On 4/12/2012 6:32 AM, Mike Turquette wrote: > From: Rajendra Nayak <[email protected]> > > Most users of clk_get_rate() actually assume a non zero > return value as a valid rate returned. Returing -EINVAL > might confuse such users, so make it instead return zero > on error. > > Besides the return value of clk_get_rate seems to be > 'unsigned long'. > > Signed-off-by: Rajendra nayak <[email protected]> > Signed-off-by: Mike Turquette <[email protected]> > Cc: Arnd Bergman <[email protected]> > Cc: Olof Johansson <[email protected]> > Cc: Russell King <[email protected]> > Cc: Sascha Hauer <[email protected]> > Cc: Shawn Guo <[email protected]> > Cc: Richard Zhao <[email protected]> > Cc: Saravana Kannan <[email protected]> > Cc: Mark Brown <[email protected]> > Cc: Andrew Lunn <[email protected]> > Cc: Viresh Kumar <[email protected]> > --- > drivers/clk/clk.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > index 9924aec..a24b121 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -285,7 +285,7 @@ unsigned long __clk_get_rate(struct clk *clk) > unsigned long ret; > > if (!clk) { > - ret = -EINVAL; > + ret = 0; > goto out; > } > > @@ -295,7 +295,7 @@ unsigned long __clk_get_rate(struct clk *clk) > goto out; > > if (!clk->parent) > - ret = -ENODEV; > + ret = 0; > > out: > return ret; > @@ -560,7 +560,7 @@ EXPORT_SYMBOL_GPL(clk_enable); > * @clk: the clk whose rate is being returned > * > * Simply returns the cached rate of the clk. Does not query the hardware. > If > - * clk is NULL then returns -EINVAL. > + * clk is NULL then returns 0. > */ > unsigned long clk_get_rate(struct clk *clk) > {
Reviewed-by: Viresh Kumar <[email protected]> -- viresh _______________________________________________ linaro-dev mailing list [email protected] http://lists.linaro.org/mailman/listinfo/linaro-dev
