In order to accommodate allowable Batteries with in the ab8500 parameters limit battery type information got bloated. (Ref: board-mop500-bm.c)
Recommended battery for snowball is: 3.7v 2600ma Ref: http://www.giga-concept.fr/media/uploads/products/documents/2008/09/9100.pdf However, i currently i am using "SonyEricsson BST41", 3.6v. 1500mAh, 5.4w Thanks, Rajanikanth On 2 July 2012 14:30, Lee Jones <lee.jo...@linaro.org> wrote: > On 29/06/12 20:44, Rajanikanth HV wrote: >> >> thanks for your review comments, i will post it on public branch, >> how about a review from abx500 bm data structure perspective >> ref: arch/arm/mach-ux500/board-mop500-bm.c > > > I already did: > > >>> It looks like you've just taken values for all of the possible >>> combinations. >>> Is this to support different batteries, or different platforms/machines? > > > The values you put into the Device Tree should be Snowball specific, but it > looks like you've loaded it up with _everything_. You need to make sure that > all of the information you put in makes sense when booting the Snowball > board. Any values which will never be used need to be extracted. > > > Kind regards, > Lee > > -- > Lee Jones > Linaro ST-Ericsson Landing Team Lead > M: +44 77 88 633 515 > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog > > _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev