On 6 July 2012 00:27, Rob Herring <robherri...@gmail.com> wrote: > I would just change arm_add_memory to use phys_addr_t for the size > param. This ultimately calls memblock functions which use phys_addr_t > for sizes.
So I have a patch that does this which basically works. However there is a bit I'm not sure about. arm_add_memory() does this: bank->size = size & PAGE_MASK; in an attempt to clear the bottom bits of the size. However, since PAGE_MASK is defined as: #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) PAGE_MASK is a 32 bit unsigned constant and so this & will clear the top 32 bits of bank->size. I'm really not sure what the best way to fix this is; suggestions? thanks -- PMM _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
