On 28 January 2013 18:16, Amit Kucheria <amit.kuche...@linaro.org> wrote: > On Mon, Jan 28, 2013 at 11:38 AM, Hongbo Zhang <hongbo.zh...@linaro.org> > wrote: >> This script aims at testing all the trip points are crossed or not, since the >> trip points are usually very high and can be reached only in extreme >> conditions >> like high environment temerature etc, in normal conditions they cannot be all >> crossed even if the CPU load is high, so failures will be reported and this >> will introduce a mess. >> Add this switch to switch off this test by default, anyone who wants to do >> this >> test still can enable it manually. > > NACK to this implementation. It should be possible to enable/disable > default tests in a single file in the top-level directory. It > shouldn't be required to go to each test script to set a variable > enable/disabling a test. > Good suggestion. There are also some other switches besides this one, I will collect them into one top level config file.
>> Signed-off-by: Hongbo Zhang <hongbo.zh...@linaro.org> >> --- >> thermal/thermal_06.sh | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh >> index 13f695d..28fdaec 100755 >> --- a/thermal/thermal_06.sh >> +++ b/thermal/thermal_06.sh >> @@ -28,6 +28,13 @@ >> source ../include/functions.sh >> source ../include/thermal_functions.sh >> >> +# test_switch: switch on/off this test >> +test_switch=0 >> +if [ "$test_switch" -eq 0 ]; then >> + log_skip "test of trip points being crossed" >> + exit 0 >> +fi >> + >> TEST_LOOP=100 >> CPU_HEAT_BIN=../utils/heat_cpu >> cpu_pid=0 >> -- >> 1.8.0 >> >> >> _______________________________________________ >> linaro-dev mailing list >> linaro-dev@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/linaro-dev _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
