On Mon, Nov 14, 2011 at 8:27 AM, Tixy (Jon Medhurst) <[email protected]> wrote: > On Fri, 2011-11-11 at 17:09 +0000, Dave Martin wrote: >> > Add vexpress_a9 platform to linaro-android-media-create >> >> Should the name "vexpress" be used instead, for consistency with >> linaro-media-create? Or does l-a-m-c use an independent set of board >> names? >> >> Other platforms based on vexpress would need to be more fully qualified >> in any case. > > For linaro-media-create we can specify all of the required board > parameters in the hardware pack so the tool doesn't need a command-line > board parameter to distinguish between vexpress flavours. > > linaro-android-media-create however needs everything hardcoded into the > tools, so we need to distinguish between vexpress core-tiles to pass the > correct memory addresses to U-Boot.
Still, I agree that we should keep the naming consistent with the names in l-m-c for code maintenance reasons and for not confusing the end user with different names for the same board. If it's important to change the name of the BoardConfig and --dev option we should also make the same change in l-m-c. The --dev option is left in l-m-c since it will be needed when there is support for multiple boards in one hwpack. > - boot_script = None > + boot_script = 'boot.scr' This change should go in the AndroidVexpressConfig so it does not break support for existing Vexpress hwpacks. That line is still in boards.py only to maintain support for old hwpacks. and will not take effect for new hwpacks anyway. Would you push your branch to launchpad and create a merge proposal so we can keep track of this change? Thanks, Mattias -- You received this bug notification because you are a member of linaro- infrastructure-drivers, which is the registrant for Linaro Image Tools. https://bugs.launchpad.net/bugs/889179 Title: Add vexpress_a9 platform to linaro-android-media-create Status in Linaro Image Tools: New Bug description: The ARM Landing Team is bringing up Android on the Versatile Express platform and linaro-android-media-create needs extending to add support for this. The attached patch does this. To manage notifications about this bug go to: https://bugs.launchpad.net/linaro-image-tools/+bug/889179/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linaro-release Post to : [email protected] Unsubscribe : https://launchpad.net/~linaro-release More help : https://help.launchpad.net/ListHelp
