Hi Andy,
I pushed some changes @ revision 449 which fixes the following:
On Thursday 15 November 2012 11:15 PM, Andy Doan wrote:
This is starting to look pretty good. I'll make a couple of nit-picks:
1) has_key
You have a couple of things like:
if testdef_repo.has_key('bzr-repo')
I think has_key is being deprecated and its more accepted to instead do:
This is done.
2) the counter in _get_test_definition_from_repo and
_get_test_definition_from_url
Then the functions can just return the array of directories and not the
tuple.
Used a timestamp value for this instead of a counter.
3) _copy_test (not sure about this comment)
This function has logic to copy the repo to the target with
shutil.copy2. I wonder if this is needed. When you look at the logic of
_configure_target, the repo cloning logic will be called while the
target's filesystem is mounted. So could we just do the bzr/git clone
straight to that directory and then avoid the copy operation later?
A bit confused on this. Unsure on how to achieve this :(
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
http://www.sasenthilkumaran.com/
_______________________________________________
linaro-validation mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-validation
