Hi Hari,

On Sat, 2013-03-23 at 00:52 +0530, Harigopal Gollamudi wrote:
> please find the attached patch. Kindly review this and update me

I went through your new patch. What I found was, the new pattern you
have put in does not relate to the old parse pattern!

-    pattern: "^(?P<test_case_id>*?)\\s+(?P<measurement>[\\d.]+)\\s
+(?P<units>\\S+)\\s+(?P<result>(pass|fail))\\s*$"
+    pattern: "^(?P<test_case_id>\\S*\\s*\\S*)\\s+(?P<measurement>\\d
+\.\\d+)\\s+(?P<units>\\S+)\\s+(?P<result>\\S+)$"

The new change is not the equivalent of the old and it is not correct (I
am concerned about the regex here). I request you to fix the above and
run a sample job in validation.linaro.org with the 0xbench yaml file.
Please include link to the sample run in your next email.

Thank You.
-- 
Senthil Kumaran
http://www.stylesen.org/
http://www.sasenthilkumaran.com/


_______________________________________________
linaro-validation mailing list
[email protected]
http://lists.linaro.org/mailman/listinfo/linaro-validation

Reply via email to