On Wed, 23 Mar 2005, Matan Ziv-Av wrote:

>
> Hello,
>
> this patch (relative to links-2.1pre17) adds rudimentary support for 
> displaying
> hebrew text in the correct direction.
> It does not include the changes for the build system, since I can't run the
> configure generated on my system from configure.in.
> For compiling and linking the new code, USE_FRIBIDI needs to be defined in
> config.h, and -lfribidi should be on the link command line. I think adding
> lines like:

Hi.

The patch contains security bug --- it allocates array of 1024 bytes on
stack and doesn't check boundaries. If an attacker creates a longer line,
he can overwrite stack return address, execute his code and break into
your computer.

Mikulas

> cf_use_bidi=no
> AC_MSG_CHECKING([if you want to use bidi])
> AC_ARG_ENABLE(bidi, [  --enable-bidi           use bidi],
> cf_use_bidi=$enableval )
> AC_MSG_RESULT($cf_use_bidi)
>
> if test "$cf_use_bidi" = yes; then
>      AC_DEFINE(USE_FRIBIDI)
>      LIBS="$LIBS -lfribidi"
> fi
>
> to configure.in should do the trick, but I am not really sure.
>
> --
> Matan Ziv-Av.                         [EMAIL PROTECTED]
_______________________________________________
links-list mailing list
links-list@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/links-list

Reply via email to