Sam,
A question and a comment...
Where did you get your kernel source from? I downloaded 2.4.24 from
kernel.org, and I don't see drivers/s390/char/hwc_rw.c in it at all.
The comment is that the problem with drivers/s390/char/ctrlchar.c has been
reported before, and a patch issued for the 2.4.21 kernel
(linux-2.4.21-s390-06-june2003.tar.gz). IBM has been having problems
getting their updates accepted into the official source tree, though, so it
didn't surprise me that the problem was still in 2.4.24.
It made me think, though, whether the "experimental" patches IBM has for
2.4.23 would apply cleanly to 2.4.24. So, I tried it, and the patches went
on without a peep. Cool, I thought. But, when I tried to compile that, the
ctrlchar.c problem was still there. Now, this _is_ a problem, because those
patches are supposed to be equivalent to the patches for the 2.4.21 kernel.
As I mentioned, the fix for ctrlchar.c was in the -06 patches for 2.4.21,
and that came out on October 31, 2003. So, it looks as though that fix got
missed somehow when the 2.4.23 patches were created. This raises the
question as to whether anything else might be missing as well, but doesn't
cause compilation errors.
I've copied the Boeblingen Lab email address on this note, so perhaps the
experimental patches can be updated to include this.
Additionally, if you turn on the crypto support, you'll find a header file
completely missing: include/asm-s390/kmap_types.h
I compared the various architecture versions of the file, and most of them
seemed to be the same, with only a few comments being different. Copying
the i386 let things compile. Whether that _works_ or not, who knows?
There was also a fix against include/asm-s390/ptrace.h that apparently never
made it into the tree:
--- linux-2.4.19/include/asm-s390/ptrace.h.bak Mon Mar 17 19:59:32 2003
+++ linux-2.4.19/include/asm-s390/ptrace.h Mon Mar 17 20:00:05 2003
@@ -129,7 +129,9 @@
{
float f;
double d;
+#if defined(__GNUC__) && !defined(__STRICT_ANSI__)
__u64 ui;
+#endif
struct
{
__u32 hi;
I remember Gerhard Tonn saying that there still wasn't a satisfactory
official fix for this, though. Perhaps there still is not.
Mark Post
-----Original Message-----
From: Samuel S Chessman [mailto:[EMAIL PROTECTED]
Sent: Monday, January 12, 2004 11:41 AM
To: [EMAIL PROTECTED]
Subject: [PATCH] s390 2.4.24 typo and missing include
The following two patches are needed to get linux 2.4.24 to compile
s390 linux. I have not had a chance to ipl to test if 2.4.24 runs
but these were necessary to compile.
The typo is only discovered if CONFIG_SMP is undefined.
Attached README and patch.
--
Sam Chessman chessman (a) tux.org
First do what's necessary, then what's possible, finally the impossible.
