> > Wouldn't it be possible to move the #ifndef into sched.h?
>
> You can't simply define it to a nop in case of SMP, because
> there it is called from a different place, but we could
> have a separate version for UP and SMP in sched.h:
>
> void update_process_times(int user_tick);
> static inline void update_process_times_nonsmp(int user_tick)
> {
> #ifndef CONFIG_SMP
> update_process_times(user_tick);
> #endif
> }
Well, the #ifndef can just be removed for most of the architectures
because they are non-smp architectures anyway. But to avoid breaking
anything I decided to play safe and move the whole #ifndef block.
It's up to the arch maintainer to remove the #ifndef if the arch
doesn't need it.
The reason for moving the #ifndef is twofold. 1) it's just confusing
that a common code function depends on CONFIG_SMP in the way do_timer
does. do_timer should do just one thing, and not two but only if this
is a non-smp kernel. 2) do_timer and update_process_times needs to get
separated to make it possible to account cputime independent of the
xtime updates.
blue skies,
Martin
Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Sch�naicherstr. 220, D-71032 B�blingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: [EMAIL PROTECTED]
----------------------------------------------------------------------
For LINUX-390 subscribe / signoff / archive access instructions,
send email to [EMAIL PROTECTED] with the message: INFO LINUX-390 or visit
http://www.marist.edu/htbin/wlvindex?LINUX-390
