Sometime between 2.4.26 and 2.4.27, changes were made to
drivers/s390/net/ctcmain.c and drivers/s390/net/netiucv.c that causes them
to not compile.  The changes were made on August 7th of this year, according
to the timestamp on the files.  (These files were obtained directly from
kernel.org.)  One thing that irritates me is that the module version numbers
were not modified on either file.  (I seem to remember complaining about
version numbers before.)

The errors that are generated are these:
ctcmain.c: In function `ctc_loglevel_read':
ctcmain.c:3099: error: `sbus' undeclared (first use in this function)
ctcmain.c:3099: error: (Each undeclared identifier is reported only once
ctcmain.c:3099: error: for each function it appears in.)
ctcmain.c: In function `ctc_stat_read':
ctcmain.c:3172: error: `sbus' undeclared (first use in this function)
make[2]: *** [ctcmain.o] Error 1

netiucv.c: In function `netiucv_buffer_read':
netiucv.c:1444: error: `ppos' undeclared (first use in this function)
netiucv.c:1444: error: (Each undeclared identifier is reported only once
netiucv.c:1444: error: for each function it appears in.)
netiucv.c: In function `netiucv_user_read':
netiucv.c:1542: error: `ppos' undeclared (first use in this function)
netiucv.c: In function `netiucv_stat_read':
netiucv.c:1609: error: `ppos' undeclared (first use in this function)
netiucv.c:1802:8: warning: extra tokens at end of #endif directive
make[2]: *** [netiucv.o] Error 1

In the case of ctcmain.c, the statements that read
   if (!*sbus || pos == 0)
can be changed to just
   if (pos == 0)
and things will compile.  Correct functioning is another matter, of course,
but that is essentially the state of the code in 2.4.26.

In the case of netiucv.c, I have no idea what should be done.  (Not that I
really do for ctcmain.c.)  These statements
   loff_t pos = *ppos;
 ...
   *ppos = pos;
were added along with some other changes.  I see that variable used in a
number of other s390-specific files, but I don't see any header files here
it is defined.

I looked at the Debian diffs for 2.4.27, and they seem to just revert these
changes back to the 2.4.26 level.  I didn't want to do that without checking
with someone who might know how to fix these problems, rather than just back
them out.  Any insight would be appreciated.


Thanks,

Mark Post

----------------------------------------------------------------------
For LINUX-390 subscribe / signoff / archive access instructions,
send email to [EMAIL PROTECTED] with the message: INFO LINUX-390 or visit
http://www.marist.edu/htbin/wlvindex?LINUX-390

Reply via email to