Greg Haerr writes:
>
> I'm not sure of the best way to fix this (some constants should
> : > be passed for the "dir" and "perm" arguments, I guess). Maybe
> : > someone more familiar with this code can offer the correct fix.
> : >
> :
> : Yep, definitly a bug, which might explain some of the bizare behavoir
> : umount(1) used to exhibit. The fixed version should look like this.
> :
> : retval = namei(name,&inode,0,0);
> :
>
> Good job, Thomas.
>
> Al - perhaps it's time we moved ELKS to ansi. We obviously could use the type
> checking. Gcc could be used to prepass most of the code, just running the compiler
> to check arguments etc. Then bcc could be used -ansi to compile the project.
>
I am not quite sure whether this is the best way to proceed. It would make
ELKS easier to find bugs in, but the -ansi option to bcc is not a very
clean solution to wanting to convert the code to ANSI. The other thing is
that it may make it harder to build the code natively under ELKS.
If we can be fairly sure that compiling ELKS with -ansi does not have any
significant downside, and we can run bcc natively under ELKS with ansi
support included, then I think this is the right way to go, but it needs to
be properly discussed before we make the decision.
Al
