Greg Haerr writes:
>
> : > if (irq < 8) {
> : > cache_21 |= 1 << irq;
> : > outb(0x21,cache_21); <--- outb(cache_21,0x21);
> : > } else {
> : > cache_A1 |= 1 << (irq-8);
> : > outb(0xA1,cache_A1); <--- outb(cache_A1,0xA1);
> :
> : Linux outb() macros are data, port
> :
>
> Yep, that code is definitely buggy. Good thing the
> whole proc is #if 0'd out ;-)
>
Yep, its incorrect, and yes it is also unused code. I have fixed it for now
in case we need it at some point.
Al
- May be mistake? Vladimir Shamaev
- Re: May be mistake? Alan Cox
- RE: May be mistake? Greg Haerr
- Alistair Riddoch
