> > >>>>> "Keith" == Keith Owens <[EMAIL PROTECTED]> writes: > > Hi, > > Just a general comment on top of Keith's. > > Keith> John Keller (on Sat, 14 Jan 2006 11:37:47 -0600 (CST)) wrote: > >> +inline uint64_t +sal_ioif_init(void) > > Keith> Make that static with no inline, let gcc decide if it should be > Keith> inlined or not. > > Please stick to using the preferred kernel internal types, u64/u32/u16 > etc. I noticed you switch u64 to uint64_t in many places which is the > wrong way to go.
Agreed. As mentioned earlier, I mistakenly posted an old version of the patch. > > Regards, > Jes > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
