>>>>> "John" == John Keller <[EMAIL PROTECTED]> writes:
John> Please disregard the earlier (01/14) post of this patch. I John> erroneously sent out an early version, which was not fully John> merged with the latest ia64 git tree. Hi John, Looks much better. On top of Prarit's comments I just noticed this one: + if (!hubdev->hdi_flush_nasid_list.widget_p) + return; + + hubdev->hdi_flush_nasid_list.widget_p = + kzalloc((HUB_WIDGET_ID_MAX + 1) * + sizeof(struct sn_flush_device_kernel *), + GFP_KERNEL); This doesn't look right, if widget_p is NULL no alloc ortherwise overwrite it? Did the order get reversed? Cheers, Jes - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
