On Mon, 6 Feb 2006 15:06:24 -0800 Moore, Robert wrote: > I meant, EXPORT_SYMBOLS is Linux-specific and belongs in a > linux-specific header (wherever the rest of the ACPICA public symbols > are exported)
a. All of these files in drivers/acpi/ use EXPORT_SYMBOL: ./bus.c ./ec.c ./events/evxface.c ./events/evxfevnt.c ./events/evxfregn.c ./glue.c ./hardware/hwregs.c ./hardware/hwsleep.c ./hardware/hwtimer.c ./namespace/nsxfeval.c ./namespace/nsxfname.c ./namespace/nsxfobj.c ./numa.c ./osl.c ./pci_bind.c ./pci_irq.c ./pci_root.c ./processor_core.c ./processor_perflib.c ./resources/rsxface.c ./scan.c ./tables/tbconvrt.c ./tables/tbxface.c ./tables/tbxfroot.c ./utilities/utdebug.c ./utilities/utglobal.c ./utilities/utxface.c ./utils.c b. Linux convention is to put EXPORT_SYMBOL[_GPL]() close to the symbol that is being exported. c. Thomas, please use "diffstat -p1" so that we get directory names in the diffstat. > > -----Original Message----- > > From: Thomas Renninger [mailto:[EMAIL PROTECTED] > > Sent: Monday, February 06, 2006 3:01 PM > > To: Moore, Robert > > Cc: ACPI-ML; Brown, Len > > Subject: Re: Convert PRINT_DEBUG(DB_ERROR/WARNING,...) to > > ACPI_ERROR/WARNING > > > > Moore, Robert wrote: > > >> Also added the EXPORT_SYMBOLS(ut_warning/error/exception) function > > > decl. > > >> in > > >> (in a separated patch -> ACPICA, acpi/utilities/utmisc.c). > > > > > > Don't these belong somewhere else? > > I thought everything in subdirs is ACPICA... > > > > > > > >> Also added errors inside remove/install handler funcs (in a > separated > > >> patch -> ACPICA, > > >> acpi/events/evxface.c). > > > > > > So, you are saying that there are insufficient error messages in > > > evxface.c, I'll look at it. > > > > > > > Grep in the big one for acpi_remove_notify_handler or > > "Error installing notify handler" ... > - > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
