Andrew, I know it's late in the 2.6.16 cycle, but it would be really
nice if this patch made it. Without it, HPETs on new HP boxes don't
work, so we're going to have to get it in the distros some way or
another.
On Sunday 12 February 2006 15:55, Bob Picco wrote:
> Bjorn Helgaas wrote: [Tue Feb 07 2006, 06:50:27PM EST]
> > When the _CRS for a single HPET contains multiple EXTENDED_IRQ
> > resources, we overwrote hdp->hd_nirqs every time we found one.
> >
> > So the driver worked when all the IRQs were described in a
> > single EXTENDED_IRQ resource, but failed when multiple resources
> > were used. (Strictly speaking, I think the latter is actually
> > more correct, but both styles have been used.)
> >
> > Someday we should remove all the ACPI stuff from hpet.c and use
> > PNP driver registration instead. But currently PNP_MAX_IRQ is 2,
> > and HPETs often have more IRQs. Hint, hint, Adam :-)
> >
> > Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]>
> >
> > Index: work-mm4/drivers/char/hpet.c
> > ===================================================================
> > --- work-mm4.orig/drivers/char/hpet.c 2006-02-07 16:18:46.000000000
> > -0700
> > +++ work-mm4/drivers/char/hpet.c 2006-02-07 16:29:00.000000000 -0700
> > @@ -953,22 +953,18 @@
> > }
> > } else if (res->type == ACPI_RESOURCE_TYPE_EXTENDED_IRQ) {
> > struct acpi_resource_extended_irq *irqp;
> > - int i;
> > + int i, irq;
> >
> > irqp = &res->data.extended_irq;
> >
> > - if (irqp->interrupt_count > 0) {
> > - hdp->hd_nirqs = irqp->interrupt_count;
> > + for (i = 0; i < irqp->interrupt_count; i++) {
> > + irq = acpi_register_gsi(irqp->interrupts[i],
> > + irqp->triggering, irqp->polarity);
> > + if (irq < 0)
> > + return AE_ERROR;
> >
> > - for (i = 0; i < hdp->hd_nirqs; i++) {
> > - int rc =
> > - acpi_register_gsi(irqp->interrupts[i],
> > - irqp->triggering,
> > - irqp->polarity);
> > - if (rc < 0)
> > - return AE_ERROR;
> > - hdp->hd_irq[i] = rc;
> > - }
> > + hdp->hd_irq[hdp->hd_nirqs] = irq;
> > + hdp->hd_nirqs++;
> > }
> > }
> >
>
> Acked-by: Bob Picco <[EMAIL PROTECTED]>
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
