At Thu, 02 Mar 2006 15:34:09 -0800,
Kristen Accardi <[EMAIL PROTECTED]> wrote:
> 
> I tested this on a couple laptops that have _DCK methods - It seems to
> work fine, however, see comment below:

Thanks for testing my patch and for feedback.

> <snip>
> 
> > Index: linux-2.6.16-rc5-mm1/drivers/pci/hotplug/acpiphp_dock.c
> > ===================================================================
> > --- linux-2.6.16-rc5-mm1.orig/drivers/pci/hotplug/acpiphp_dock.c
> > +++ linux-2.6.16-rc5-mm1/drivers/pci/hotplug/acpiphp_dock.c
> > @@ -290,6 +290,7 @@ handle_hotplug_event_dock(acpi_handle ha
> >                     dbg("EJECT request\n");
> >                     if (!dock_in_progress() && dock_present()) {
> >                             hotplug_pci(type);
> > +                           acpiphp_bus_trim(handle);
> 
> This is not necessary.  hotplug_pci() will pass the eject event down to
> the acpiphp handle_hotplug_event_func() routine, which will call
> disable_device() and remove the bus that way as part of your new patch.

OK, I mis-understood the dock eject routine.
I'll remove it.

> >                             undock();
> >                             eject_dock();
> >                             if (dock_present())

Thanks,
MUNE
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to