Yasunori Goto <[EMAIL PROTECTED]> wrote: > > > WARNING: "remove_memory" [drivers/acpi/acpi_memhotplug.ko] undefined! > > WARNING: "add_memory" [drivers/acpi/acpi_memhotplug.ko] undefined! > > WARNING: "acpi_os_allocate" [drivers/acpi/acpi_memhotplug.ko] undefined! > > > > Does it actually make sense to load acpi_memhotplug.ko as a module? Will > > it all work? > > Are these warning 2.6.16-rc6-mm2? > I tried it on ia64. > If EXPORT_SYMBOL_GPL for them are defined, it worked well as a module. > Probably, x86-64 will work by same definition. > > In 2.6.16 stock kernel, EXPORT_SYMBOL is already defined for > add_memory() and remove_memory() of x86-64. (only x86-64, not for ia64). > acpi_os_allocate() is not called in acpi_memhotplug.ko of 2.6.16. > it is called only on 2.6-16-rc6-mm2. >
I think the problem was introduced by one of the newly-queued patches in Andi's tree, possibly ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/patches/hotadd-reserve If acpi_memhotplug.ko works OK as a module then I guess adding the exports is the right fix. - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
