On Tuesday 15 August 2006 01:37, [EMAIL PROTECTED] wrote: > From: William Morrrow <[EMAIL PROTECTED]> > > This was discovered on a broken BIOS that simply returned from its suspend > procedure, appearing to the OS as a failed S3 attempt. > > It is possible to invoke the protected mode register restore routine (which > would normally restore the sysenter registers) when the bios returns from > S3. This has no effect on a correctly running system and repairs the > damage from broken BIOS.
Where and why does acpi_enter_sleep_state() bail out? Does S3 work on windows on this box? How does the machine fail without this patch -- does it crash or hang on entering S3? Does the patch below imply that we've got the return from acpi_enter_sleep_state wrong no matter why it returns? thanks, -Len > Signed-off-by: William Morrow <[EMAIL PROTECTED]> > Signed-off-by: Jordan Crouse <[EMAIL PROTECTED]> > Cc: "Yu, Luming" <[EMAIL PROTECTED]> > Cc: "Brown, Len" <[EMAIL PROTECTED]> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> > --- > > arch/i386/kernel/acpi/wakeup.S | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff -puN > arch/i386/kernel/acpi/wakeup.S~acpi-correctly-recover-from-a-failed-s3-attempt > arch/i386/kernel/acpi/wakeup.S > --- > a/arch/i386/kernel/acpi/wakeup.S~acpi-correctly-recover-from-a-failed-s3-attempt > +++ a/arch/i386/kernel/acpi/wakeup.S > @@ -292,7 +292,10 @@ ENTRY(do_suspend_lowlevel) > pushl $3 > call acpi_enter_sleep_state > addl $4, %esp > - ret > + > +# In case of S3 failure, we'll emerge here. Jump > +# to ret_point to recover > + jmp ret_point > .p2align 4,,7 > ret_point: > call restore_registers > _ > - > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
