From: Alexey Dobriyan <[EMAIL PROTECTED]>

* This reporting is useless (you get errno anyway).
* This reporting is already inconsistent in driver.
* Looks like created files in proc are rw-rw-rw- by default.

Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---

 drivers/acpi/asus_acpi.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff -puN 
drivers/acpi/asus_acpi.c~asus_acpi-dont-printk-on-writing-garbage-to-proc-files 
drivers/acpi/asus_acpi.c
--- 
a/drivers/acpi/asus_acpi.c~asus_acpi-dont-printk-on-writing-garbage-to-proc-files
+++ a/drivers/acpi/asus_acpi.c
@@ -629,9 +629,7 @@ proc_write_ledd(struct file *file, const
                               "Asus ACPI: LED display write failed\n");
                else
                        hotk->ledd_status = (u32) value;
-       } else if (rv < 0)
-               printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
+       }
        return rv;
 }
 
@@ -849,10 +847,7 @@ proc_write_brn(struct file *file, const 
                value = (0 < value) ? ((15 < value) ? 15 : value) : 0;
                /* 0 <= value <= 15 */
                set_brightness(value);
-       } else if (rv < 0) {
-               printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
        }
-
        return rv;
 }
 
@@ -897,9 +892,6 @@ proc_write_disp(struct file *file, const
        rv = parse_arg(buffer, count, &value);
        if (rv > 0)
                set_display(value);
-       else if (rv < 0)
-               printk(KERN_WARNING "Asus ACPI: Error reading user input\n");
-
        return rv;
 }
 
_
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to