On Sun, Jul 29, 2007 at 12:40:16PM -0400, Luming Yu wrote:
>       switch (event) {
>       case ACPI_VIDEO_NOTIFY_SWITCH:  /* User requested a switch,
>                                        * most likely via hotkey. */
>               acpi_bus_generate_event(device, event, 0);
> +             keycode = KEY_UNKNOWN;

KEY_SWITCHVIDEOMODE ?

> 
>       case ACPI_VIDEO_NOTIFY_PROBE:   /* User plugged in or removed a video
> @@ -1734,21 +1741,37 @@ static void acpi_video_bus_notify(acpi_h
>               acpi_video_device_rebind(video);
>               acpi_video_switch_output(video, event);
>               acpi_bus_generate_event(device, event, 0);
> +             keycode = KEY_UNKNOWN;
>               break;

Here too.

>       case ACPI_VIDEO_NOTIFY_SWITCH:  /* change in status (cycle output 
> device) */
>       case ACPI_VIDEO_NOTIFY_PROBE:   /* change in status (output device 
> status) */
>               acpi_bus_generate_event(device, event, 0);
> +             keycode = KEY_UNKNOWN;
>               break;

And these? I'm not sure in this case, though.

> +#define KEY_VIDEO_NEXT               0x1f9
> +#define KEY_VIDEO_PREV               0x1fa
> +#define KEY_BRIGHTNESS_UP    0x1fb
> +#define KEY_BRIGHTNESS_DOWN  0x1fc

What's wrong with the existing KEY_BRIGHTNESSDOWN and KEY_BRIGHTNESSUP?

> +#define KEY_BRIGHTNESS_ZERO  0x1fd
> +#define KEY_BRIGHTNESS_OFF   0x1fe

You almost certainly want to go via linux-input if you're adding new 
keycodes.

-- 
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to