On Wednesday 10 October 2007 11:47:39 pm Andrew Morton wrote: > On Fri, 28 Sep 2007 10:39:14 -0600 Bjorn Helgaas <[EMAIL PROTECTED]> wrote: > > > --- w.orig/include/linux/pnp.h 2007-09-13 16:25:48.000000000 -0600 > > +++ w/include/linux/pnp.h 2007-09-13 16:26:04.000000000 -0600 > > @@ -8,6 +8,10 @@ > > > > #ifdef __KERNEL__ > > > > +#ifdef CONFIG_PNP_DEBUG > > +#define DEBUG > > +#endif > > In file included from include/linux/isapnp.h:26, > from drivers/pcmcia/i82365.c:58: > include/linux/pnp.h:12:1: warning: "DEBUG" redefined > <command line>:1:1: warning: this is the location of the previous definition > > testing problems?
I didn't use the correct idiom for turning on DEBUG, and I didn't built with allyesconfig (sorry), so didn't notice. Can you add the patch below, please? PNP: turn on -DDEBUG when CONFIG_PNP_DEBUG is enabled We now use dev_dbg(), which is enabled when DEBUG is defined. Signed-off-by: Bjorn Helgaas <[EMAIL PROTECTED]> Index: w/drivers/pnp/Makefile =================================================================== --- w.orig/drivers/pnp/Makefile 2007-10-11 08:59:13.000000000 -0600 +++ w/drivers/pnp/Makefile 2007-10-11 09:04:46.000000000 -0600 @@ -7,3 +7,7 @@ obj-$(CONFIG_PNPACPI) += pnpacpi/ obj-$(CONFIG_PNPBIOS) += pnpbios/ obj-$(CONFIG_ISAPNP) += isapnp/ + +ifeq ($(CONFIG_PNP_DEBUG),y) +EXTRA_CFLAGS += -DDEBUG +endif - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
