Pavel Emelyanov [[email protected]] wrote:
| Sukadev Bhattiprolu wrote:
| >
| > Subject: [RFC][v8][PATCH 4/10]: Add target_pid parameter to alloc_pidmap()
| >
|
| [ snip ]
|
| > @@ -146,16 +146,22 @@ static int alloc_pidmap_page(struct pidm
| > return 0;
| > }
| >
| > -static int alloc_pidmap(struct pid_namespace *pid_ns)
| > +static int alloc_pidmap(struct pid_namespace *pid_ns, int target_pid)
|
| Please no! Better create another function, that will just
| atomic_test_and_set() the proper bit in the map. This one
| is heavy enough already.
I had a set_pidmap() function before:
http://lkml.org/lkml/2009/8/7/24
but dropped it based on some comments and the current version evolved
from it. I could go back to that if it still makes sense.
Thanks,
Sukadev
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
