On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote: > On śro, 2014-08-27 at 14:50 +0100, Lee Jones wrote: > > On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote: > > > > > Remove hard-coded values for: > > > - Fast Charge current, > > > - End Of Charge current, > > > - Fast Charge timer, > > > - Overvoltage Protection Threshold, > > > - Battery Constant Voltage, > > > and use DTS or sysfs to configure them. This allows using the max14577 > > > charger > > > driver with different batteries. > > > > > > Now the charger driver requires valid configuration data from DTS. In > > > case of wrong configuration data it fails during probe. Patch adds > > > of_compatible to the charger mfd cell in MFD driver core. > > > > > > The fast charge timer is configured through sysfs entry. > > > > > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > > Cc: Kyungmin Park <[email protected]> > > > Cc: Dmitry Eremin-Solenikov <[email protected]> > > > Cc: David Woodhouse <[email protected]> > > > Cc: Jenny Tc <[email protected]> > > > Cc: Mark Rutland <[email protected]> > > > Acked-by: Lee Jones <[email protected]> > > > --- > > > drivers/mfd/max14577.c | 5 +- > > > > Hmm... not sure why I Acked this. The code looks okay, but can you > > break out the MFD changed into a separate patch please? You can add > > my Ack to the broken out patch though. > > Sure, I'll split it however the compatible here in mfd_cell makes sense > only with this patch.
That's completely fine. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
