On Thu, Jan 29, 2015 at 06:59:59PM +0100, Yann Droneaud wrote: > This patch ensures the extended QUERY_DEVICE uverbs request's > comp_mask has only known and supported bits (currently none).
I think I would be happy to see the input comp_mask removed entirely. I can't see a possible use for input data to a QUERY command that wouldn't be better served by creating a new command But forcing the value to 0 seems reasonable as well. Reviewed-By: Jason Gunthorpe <[email protected]> Also, the _ex varients were supposed to be supersets of the base call, so it is wrong that query_device_ex doesn't return all the same data as query_device, layed out so that the original response structure is a prefix of the extended response structure. The other _ex calls in verbs were designed that way so it will be surprising to the user that this one is different. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
