----- On Sep 3, 2015, at 8:26 AM, Helge Deller [email protected] wrote: > Hi Mathieu, > >> [ Untested on this architecture. To try it out: fetch linux-next/akpm, >> apply this patch, build/run a membarrier-enabled kernel, and do make >> kselftest. ] >> >> Signed-off-by: Mathieu Desnoyers <[email protected]> >> CC: Andrew Morton <[email protected]> >> CC: [email protected] >> CC: "James E.J. Bottomley" <[email protected]> >> CC: Helge Deller <[email protected]> >> CC: [email protected] >> --- >> arch/parisc/include/uapi/asm/unistd.h | 3 ++- >> arch/parisc/kernel/syscall_table.S | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/parisc/include/uapi/asm/unistd.h >> b/arch/parisc/include/uapi/asm/unistd.h >> index 2e639d7..dadcada 100644 >> --- a/arch/parisc/include/uapi/asm/unistd.h >> +++ b/arch/parisc/include/uapi/asm/unistd.h >> @@ -358,8 +358,9 @@ >> #define __NR_memfd_create (__NR_Linux + 340) >> #define __NR_bpf (__NR_Linux + 341) >> #define __NR_execveat (__NR_Linux + 342) >> +#define __NR_membarrier (__NR_Linux + 343) >> >> -#define __NR_Linux_syscalls (__NR_execveat + 1) >> +#define __NR_Linux_syscalls (__NR_membarrier + 1) >> >> >> #define __IGNORE_select /* newselect */ >> diff --git a/arch/parisc/kernel/syscall_table.S >> b/arch/parisc/kernel/syscall_table.S >> index 8eefb12..2faa43b 100644 >> --- a/arch/parisc/kernel/syscall_table.S >> +++ b/arch/parisc/kernel/syscall_table.S >> @@ -438,6 +438,7 @@ >> ENTRY_SAME(memfd_create) /* 340 */ >> ENTRY_SAME(bpf) >> ENTRY_COMP(execveat) >> + ENTRY_COMP(membarrier) > > This needs to be ENTRY_SAME(membarrier), since you don't have/need a > compat_membarrier() function.
Allright, will fix. > > After changing to ENTRY_SAME() I did run the kselftest on parisc: > deller@ls3xx> ./membarrier_test > membarrier MEMBARRIER_CMD_QUERY syscall available. > membarrier: MEMBARRIER_CMD_SHARED success. > membarrier: tests done! And add your Tested-by tag, thanks! Mathieu > > Helge -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-api" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
