On Fri, 4 Feb 2005 19:29:17 -0800 (PST)
Linus Torvalds <[EMAIL PROTECTED]> wrote:

> For example, replacing TASK_SIZE in fs/namei.c with "thread->addr_limit" 
> would actually clean up the code: it would mean that the games with 
> "get_fs()" etc would just go away, to be replaced with something like

I think that looks nice too.

Would you be against a "mm->addr_limit"?  That's what an approach
by Paulus implemented, and I was in the camp supporting that kind
of direction.

"mm"'s exist potentially long after the "thread" part goes away.
That's why my position is that logically any "limit" on the address
space is an mm property.

And thusly, this is what that mmap() et al. stuff should be checking
not some arg'less macro called TASK_SIZE.

As an aside, while I realize the bad side effects of making
USER_PTRS_PER_PGD dynamic, it makes 32-bit process teardown
a lot faster so it's no surprise all the platforms do it.

Reply via email to