On Fri, 18 Feb 2005 16:22:29 +1100 Stephen Rothwell <[EMAIL PROTECTED]> wrote: > > On Tue, 15 Feb 2005 18:43:07 +0000 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > > On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: > > > > > +asmlinkage long compat_sys_waitid(u32 which, u32 pid, > > > + struct compat_siginfo __user *uinfo, u32 options, > > > + struct compat_rusage __user *uru) > > > > Some subtle differences which I feel incompetent to diagnose ... ours > > looks like: > > > > asmlinkage int compat_sys_waitid(int which, pid_t pid, > > compat_siginfo_t __user *infop, int > > options, > > struct compat_rusage __user *ru) > > They are u32 in my version because we decided that the kernel zero extends > the compat syscall parameters.
On second thoughts, I think we should be more consistent with other compat_sys_ routines. New patch following. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
