>This is the i386 cpu hotplug patch.  It's been in -mm for eons.
>
>I was planning on merging it post-2.6.12 because several 
>power-management
>related projects will use infrastructure which it provides.

But my local cpu hotplug expert (Ashok) has this to say about
the irq redirection part of the i386 code:

On i386, the way they do in fixup_irqs() to 

  Redirect interrupts
  Local_irq_enable() // hack to permit irq processing
  Mdelay();; hack to wait
  Local_irq_disable()

Is totally not the right solution, there are easy cases that a race
condition can be triggered, and chipsets can also lockup if you do
programming the rte's without disabling them first.

This really ought to be fixed before putting it into production
kernels.

They also need to change irq to deferred mode when we do proc/irq
write handling like what we do for ia64.


-Tony

Reply via email to