Hi Nick, > s390 - local irq disable before checking need_resched doesn't gain > anything (removed, OK?)
Well, currently there seems to be only the pfault interrupt that can set TIF_NEED_RESCHED and pfault interrupts can't happen for idle. So it should work. But if there is any chance that an interrupt will ever set TIF_NEED_RESCHED we have to disable the interrupts before doing the resched check. As I implemented this I wanted to make absolutly sure that we don't miss any reschedule. It works the way it is and the additional cycles in idle() for local_irq_disable/local_irq_enable won't hurt. I don't see the benefit of the change. Only chances that it might break something we haven't thought of. blue skies, Martin Martin Schwidefsky Linux for zSeries Development & Services IBM Deutschland Entwicklung GmbH
