On Wed, Nov 09, 2005 at 06:49:32AM -0700, Matthew Wilcox wrote:
> On Wed, Nov 09, 2005 at 03:30:23PM +0200, Paul Mundt wrote:
> > > +#define SA_TRIGGER_LOW           0x00000004
> > > +#define SA_TRIGGER_RISING        0x00000002
> > > +#define SA_TRIGGER_FALLING       0x00000001
> > It probably makes sense to move SA_TRIGGER here as well, as it's going to
> > be a pretty common mask. Otherwise everyone that plans to make use of
> > this will likely end up duplicating it.
> 
> Are there any other architectures that plan to make use of this?

Just to be clear - the primary reason I'm putting these in a shared
file is that we don't want to add #ifdefs to drivers (which is what
would be necessary if it was placed in asm-arm.)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

Reply via email to