On Mon, Jan 23, 2006 at 09:07:55PM -0800, David S. Miller wrote:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Tue, 24 Jan 2006 01:13:39 +0100
> > On Tuesday 24 January 2006 01:07, Kyle McMartin wrote:
> > > +/* Arches may override __is_compat_task from asm/compat.h */
> > I don't think this particular patch is a good idea. PER_LINUX32 means
> > something completely different than you think on many architectures.
> > You can't do a default for it.
>
> Indeed, it is definitely preferable to just flat out break
> the build than give a bogus default.
>
Sounds fine to me.
> If the build breaks, you see the failure and the platform
> maintainer makes sure the correct implementation is made.
> If it silently just builds, you end up with potential silent
> failures which just sucks :)
Alrighty, would there by any objection to ripping out the
`generic' __is_compat_task and letting this sit in -mm for arch
maintainers to fix their builds?
Thanks,
Kyle
-
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
